Repository navigation
fix(tron): allow confirmation after simulation failures - #552
Merged
Merged
Conversation
taran-a
temporarily deployed
to
default-branch
November 4, 2026 08:25 — with
GitHub Actions
Inactive
taran-a
force-pushed
the
fix/tron-simulation-confirm
branch
2 times, most recently
from
November 4, 2026 08:26
cc93ed3 to
5b8de7d
Compare
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Battambang
reviewed
Nov 4, 2026
Battambang
reviewed
Nov 4, 2026
taran-a
force-pushed
the
fix/tron-simulation-confirm
branch
from
November 4, 2026 10:53
5b8de7d to
e1702e9
Compare
|
taran-a
enabled auto-merge
November 4, 2026 11:01
Battambang
approved these changes
Nov 4, 2026
Battambang
left a comment
Contributor
There was a problem hiding this comment.
gj there with the fix
This was referenced Nov 4, 2026
Merged
n3ps
pushed a commit
to n3ps/metamask-extension
that referenced
this pull request
Nov 4, 2026
…aMask#47621) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** # Bitcoin [3.3.0] ### Changed - Retry transient Bitcoin indexer, price API, and signed transaction broadcast failures with the shared fetch policy, and treat duplicate broadcasts as successful. ([MetaMask#530](MetaMask/internal-snaps#530)) ### Fixed - Fix formatting of small Bitcoin balances to avoid scientific notation. ([MetaMask#543](MetaMask/internal-snaps#543)) # Tron [4.3.1] ### Fixed - Allow transaction confirmation after remote simulation failures while retaining security warnings and checks for locally invalid transactions. ([MetaMask#552](MetaMask/internal-snaps#552)) <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** n/a ## **Manual testing steps** n/a ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Patch bumps change Bitcoin broadcast/retry behavior and Tron confirmation when remote simulation fails, both on transaction-critical paths. > > **Overview** > Bumps **`@metamask/bitcoin-wallet-snap`** to **3.3.0** and **`@metamask/tron-wallet-snap`** to **4.3.1** in `package.json`, with matching **`yarn.lock`** resolutions. No extension source changes—behavior comes from the new snap builds. > > With **Bitcoin 3.3.0**, users get more resilient indexer/price/broadcast calls (shared fetch retries, duplicate broadcasts treated as success) and corrected display of very small balances (no scientific notation). > > With **Tron 4.3.1**, confirmation can proceed when **remote** simulation fails, while locally invalid transactions still block approval and security warnings remain. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4bd1b01. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
5 of 10 tasks
anxolin
pushed a commit
to anxolin/internal-snaps
that referenced
this pull request
Nov 7, 2026
## Explanation # Bitcoin [3.3.0] ### Changed - Retry transient Bitcoin indexer, price API, and signed transaction broadcast failures with the shared fetch policy, and treat duplicate broadcasts as successful. ([MetaMask#530](MetaMask#530)) ### Fixed - Fix formatting of small Bitcoin balances to avoid scientific notation. ([MetaMask#543](MetaMask#543)) # Tron [4.3.1] ### Fixed - Allow transaction confirmation after remote simulation failures while retaining security warnings and checks for locally invalid transactions. ([MetaMask#552](MetaMask#552)) <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
Allow transaction confirmation after remote simulation failures while retaining security warnings and checks for locally invalid transactions.
Before:

After:

References
Fixes WPN-2276
Checklist